Add margin outlier filter #114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -163,24 +196,77 @@ def _get_unexpected_units(self, aggregates): | |||
|
|
|||
| return unexpected_units | |||
|
|
|||
| def _get_non_modeled_units(self, percent_reporting_threshold, turnout_factor_lower, turnout_factor_upper): | |||
| expected_geographic_units = self._get_expected_geographic_unit_fips().tolist() | |||
| def _fit_outlier_detection_model(self, reporting_units, response_variable, outlier_z_threshold): | |||
There was a problem hiding this comment.
Do you have a sense of:
- how much better this works compared to say, mean ± (
z* standard deviation) or the IQR method? - how much additional runtime this adds on to the model?
🤔
|
|
||
|
|
||
| if "margin" in self.estimands: | ||
| # reporting_units["normalized_margin_change"] = ( |
There was a problem hiding this comment.
Do you want to keep this commented-out code? 🤔
Also can you remove the extra blank line above if "margin" in self.estimands? I am genuinely surprised pre-commit didn't remove that lol 🤔
| @@ -1024,6 +1024,7 @@ def compute_bootstrap_errors( | |||
| self.weighted_z_test_pred = z_test_pred * weights_test | |||
| self.ran_bootstrap = True | |||
| self.n_contests = aggregate_indicator.shape[1] | |||
| # import IPython; IPython.embed() | |||
There was a problem hiding this comment.
Can you remove this? (Also I had never heard of IPython.embed() before and it's cool 😄 )
| assert reporting_data.shape[0] == 133 - over | ||
|
|
||
|
|
||
| def test_unit_blacklist(va_governor_county_data, rng): |
There was a problem hiding this comment.
I'm fine with either "blocklist" or "blacklist", so can you either change this to "blocklist" or change CombinedDataHandler to "blacklist"? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding an outlier detection for margin outliers also (in addition to the turnout outliers, which we already have). Also added the ability to blacklist units (or even entire states).
Jira Ticket
Test Steps
Running the testbed like this will show
3352100and21083be printed as unexpected units. And all Maryland units also: