-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elex 2770/2771 OLS and new quantile regression #11
Conversation
Hi! Thanks for submitting this PR! Code-wise, I think it looks great! 🎉 But can you help me understand these changes conceptually? 😅 Specifically:
Thanks! |
Absolutely!
|
Whoa! This is awesome! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 🎉
Description
This is one PR for two tickets: elex-2770 and elex-2771.
Elex-2770 adds a bootstrap optimized ordinary least squares implementation to elex-solver.
Elex-2771 updates our quantile implementation to solve the dual problem in the non-regularized case. At the moment we keep our old cvxpy implementation for the case where we run the solver with regularization. Eventually we will want to replace this with the dual problem also.
Also updated the python version that the unit tests run for from 3.7/3.8 to 3.10/3.11.
Jira Ticket
https://arcpublishing.atlassian.net/browse/ELEX-2770
https://arcpublishing.atlassian.net/browse/ELEX-2771
Test Steps
tox
works