feat(*): support actor_scaled event #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brooks Townsend <[email protected]> whoops Signed-off-by: Brooks Townsend <[email protected]>
Signed-off-by: Brooks Townsend <[email protected]>
Signed-off-by: Brooks Townsend <[email protected]>
brooksmtownsend
force-pushed
the
feat/actor_scaled
branch
from
57b7aab
to
1899d31
Compare
connorsmith256
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This PR adds support for the
actor_scaledevent which will allow the lattice observer to modify the instances state with the single event instead of handling the individualactor_started/actor_stoppedevents. I'm leapfrogging the plural events here as we didn't have support for them and after wasmCloud v0.82 is released we won't need them anyways.There will be another PR shortly supporting the new heartbeat format which will also make it into 0.5.0.
Related Issues
The actor scaled event includes the image ref, which could enable #16
Release Information
0.5.0
Consumer Impact
No consumer impact as this event isn't even released yet.
Testing
Unit Test(s)
Added a unit test to validate functionality. All instance IDs are just supplanted as
N/Aas they don't matter.Acceptance or Integration
Manual Verification