chore(wasix): Avoid redundant hashing when spawning commands #5415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When loading modules for package commands, re-use the hash from the command to avoid redundant re-hashing, which can be quite expensive.
|
✅ No documentation updates required. |
Arshia001
requested changes
Feb 19, 2025
| }); | ||
| } | ||
| [first] => first, | ||
| [_first, ..] => { |
There was a problem hiding this comment.
This time around, I'm not approving this 😄 this case can be merged with the empty slice case.
There was a problem hiding this comment.
Buuut it's supposed to signal a difference between "no commands" and "multiple commands, don't know which to pick".
We can extend the error with a message to reflect this (that also mentions the command names).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading modules for package commands, re-use the hash from the
command to avoid redundant re-hashing, which can be quite expensive.