Merge with upstream #114
Merged
Merge with upstream #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ealliance#1669) This commit updates the logic when merging WIT packages together to better handle stability. This isn't perfect but it should suffice to fix the issue in bytecodealliance#1666. The general idea is that stability is something that needs to be specifically handled during the merging process and it erroneously wasn't processed at all before. This commit fixes that and fixes a panic along the way. Stability is now inherited if possible but generates an error if two packages disagree. Closes bytecodealliance#1666
…e#1670) This commit is an implementation of WebAssembly/component-model#368 in this repository. The intention here is along the lines of a few other recent restrictions which is to avoid outright removing support and instead stage the changes a bit. To that end a new feature flag is added and multi-return functions are now gated behind this feature flag. Tests are updated to avoid using it and otherwise the actual removal of supporting code is deferred to a later date.
…liance#1675) * [wit-parser] select default world among multiple packages Previously, `Resolve::select_world` would return an error if multiple packages were provided and no world was specified. Now, we return `Ok` in this case as long as exactly one package has exactly one world. Signed-off-by: Joel Dice <[email protected]> * add `multiple-packages-one-world` test Signed-off-by: Joel Dice <[email protected]> * add sad-path tests for multiple packages Signed-off-by: Joel Dice <[email protected]> --------- Signed-off-by: Joel Dice <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.