Introduce middleware for job error handling #2502
Open
+73
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes wasp-lang#2475 Introduce default error logging middleware for jobs to avoid server crashes. * Add `errorLoggingMiddleware` function in `waspc/data/Generator/templates/sdk/wasp/server/middleware/globalMiddleware.ts` to log errors and prevent job crashes. * Update `mage/src/server/jobs/checkForPendingApps.ts` to wrap the `checkForPendingApps` job handler with `errorLoggingMiddleware`. * Update `mage/src/server/jobs/failStaleGenerations.ts` to wrap the `failStaleGenerations` job handler with `errorLoggingMiddleware`. * Update documentation in `web/docs/advanced/jobs.md` to include information about the new default error logging middleware for jobs. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/wasp-lang/wasp/issues/2475?shareId=XXXX-XXXX-XXXX-XXXX).
|
Thanks for the contribution, did you test this locally successfully? |
|
Yes, I have tested these changes locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2475
Introduce default error logging middleware for jobs to avoid server crashes.
errorLoggingMiddlewarefunction inwaspc/data/Generator/templates/sdk/wasp/server/middleware/globalMiddleware.tsto log errors and prevent job crashes.mage/src/server/jobs/checkForPendingApps.tsto wrap thecheckForPendingAppsjob handler witherrorLoggingMiddleware.mage/src/server/jobs/failStaleGenerations.tsto wrap thefailStaleGenerationsjob handler witherrorLoggingMiddleware.web/docs/advanced/jobs.mdto include information about the new default error logging middleware for jobs.