KBHDP RPT 2 and Modify REFLOSystemCosting #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tialization logging
…osting_package.py
…osting_package.py
…menting key function calls in KBHDP_RPT_2.py, FPC.py, LTMED.py, and translator_4.py
…ll injection and FPC components
…costing components
…HDP_RPT_2 analysis
There was a problem hiding this comment.
Copilot reviewed 10 out of 25 changed files in this pull request and generated 3 suggestions.
Files not reviewed (15)
- src/watertap_contrib/reflo/analysis/case_studies/KBHDP/components/ro_system.py: Evaluated as low risk
- src/watertap_contrib/reflo/analysis/case_studies/KBHDP/utils/init.py: Evaluated as low risk
- src/watertap_contrib/reflo/analysis/case_studies/KBHDP/tests/test_RPT_2.py: Evaluated as low risk
- src/watertap_contrib/reflo/analysis/case_studies/KBHDP/components/translator_4.py: Evaluated as low risk
- src/watertap_contrib/reflo/analysis/case_studies/KBHDP/components/translator_3.py: Evaluated as low risk
- src/watertap_contrib/reflo/analysis/case_studies/KBHDP/components/translator_2.py: Evaluated as low risk
- src/watertap_contrib/reflo/analysis/case_studies/KBHDP/components/init.py: Evaluated as low risk
- src/watertap_contrib/reflo/analysis/case_studies/KBHDP/components/deep_well_injection.py: Evaluated as low risk
- src/watertap_contrib/reflo/core/solar_energy_base.py: Evaluated as low risk
- src/watertap_contrib/reflo/analysis/case_studies/KBHDP/components/PV.py: Evaluated as low risk
- src/watertap_contrib/reflo/costing/watertap_reflo_costing_package.py: Evaluated as low risk
- src/watertap_contrib/reflo/analysis/case_studies/KBHDP/init.py: Evaluated as low risk
- src/watertap_contrib/reflo/data/technoeconomic/ultra_filtration.yaml: Evaluated as low risk
- src/watertap_contrib/reflo/analysis/case_studies/KBHDP/components/UF.py: Evaluated as low risk
- src/watertap_contrib/reflo/data/technoeconomic/electrocoagulation.yaml: Evaluated as low risk
Comments skipped due to low confidence (2)
src/watertap_contrib/reflo/analysis/case_studies/KBHDP/components/FPC.py:143
- The
blkparameter is used but not defined in the function signature. It should be added to the function signature.
def add_FPC_scaling(m, blk):
src/watertap_contrib/reflo/analysis/case_studies/KBHDP/components/LTMED.py:62
- [nitpick] The function name
_initializestarts with an underscore, which is typically used for private methods. Since this function is used in other parts of the code, it should be renamed toinitializeto avoid confusion.
def _initialize(blk, verbose=False):
src/watertap_contrib/reflo/analysis/case_studies/KBHDP/components/FPC.py
Outdated
Show resolved
Hide resolved
| else: | ||
| print("\n--------- FAILED SOLVE!!! ---------\n") | ||
| print(msg) | ||
| assert False |
There was a problem hiding this comment.
The assertion assert False will always fail. It should be removed or replaced with appropriate error handling.
Suggested change
| assert False | |
| return None |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
|
|
||
|
|
||
| def calc_scale(value): | ||
| if value != 0 or value != None: |
There was a problem hiding this comment.
The condition should be 'if value != 0 and value is not None:' to correctly handle None values.
Suggested change
| if value != 0 or value != None: | |
| if value != 0 and value is not None: |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
…DP_RPT_2.py and EC.py
…lectricity sold reporting in PV
…into pr/zacharybinger/141
kurbansitterley
changed the title
kurbansitterley
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating PR for RPT2Case Study
This case study includes EC, UF, LTMED, DWI powered by FPC.
This PR also removes
aggregate_flow_heat_soldandaggregate_flow_electricity_soldand associated constraints and tests. These_soldvariables variables were always zero in all use cases to date, and this was causing stability and solve issues for these case studies. If it is desired to add these variables/constraints back in toREFLOSystemCostingin the future, a "frozen" version of the previous costing package is available here as a starting point:https://github.com/kurbansitterley/watertap-reflo/tree/costing_package_freeze