Updates needed to use watertap==1.2.0 as dependency #167
+243
−192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… watertap setup.py
kurbansitterley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates units in some variables and constraints in both the
CrystallizerEffectandMultiEffectCrystallizermodel necessary to usewatertap>=1.0.0as dependency for WaterTAP-REFLO.There were some unit changes made in the crystallizer property package before the watertap 1.0.0 release that were not compatible with the first implementation of both of these crystallizer models. At the time, we decided to just use 1.0.0rc0 and punted making the changes necessary for using the 1.0.0 release. This PR makes those changes necessary.
Primary motivation for using watertap>=1.0.0 is inclusion of the LCOW breakdowns that were implemented in the WaterTAP costing package in 1.0.0, which will be inherited by the REFLO costing packages once this PR is merged.