Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MONIT-40444: Pixie script changes for handling raw ebpf data and eBPF… #272

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

zen10001
Copy link

This ticket is the pixie script changes for MONIT-40224 and MONIT-40568

Design document for a New Sampling Strategy for eBPF traffic(MONIT-40224) is here https://confluence.eng.vmware.com/pages/viewpage.action?spaceKey=WFENG&title=Design+Doc+for+a+New+Sampling+Strategy+for+eBPF+traffic

MONIT-40568 is for handling raw ebpf traffic in Application Topology. i.e. We no longer need to generate the synthetic parent span for pixie traffic, thus cutting the tracing data by half.

@oppegard
Copy link
Contributor

@zen10001 we need to hold off on merging this since customers will be using the PxL script directly from main. We'll need to figure out the upgrade path (if any is needed), once MONIT-40224 and MONIT-40568 are available to the beta customers.

@zen10001
Copy link
Author

@zen10001 we need to hold off on merging this since customers will be using the PxL script directly from main. We'll need to figure out the upgrade path (if any is needed), once MONIT-40224 and MONIT-40568 are available to the beta customers.

understand. won't merge into main until after beta release. Just for review and testing.

@zen10001 zen10001 force-pushed the main branch 2 times, most recently from a4c2dac to b1d7a8e Compare September 18, 2023 19:19
@oppegard
Copy link
Contributor

@zen10001 we changed how we use PxL scripts since PR was opened. They're now deployed as K8s ConfigMaps (removing the need for the Pixie control plane to deploy PxL scripts):

Could you update the ConfigMaps with these changes, so this PR can remain the source of truth for when we eventually merge it?

ginwoopak added a commit that referenced this pull request Oct 23, 2023
github-actions bot pushed a commit that referenced this pull request Nov 3, 2023
ginwoopak added a commit that referenced this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants