Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data and config paths to match platform defaults #1047

Merged
merged 23 commits into from
Oct 22, 2024

Conversation

esimkowitz
Copy link
Member

@esimkowitz esimkowitz commented Oct 16, 2024

Going forward for new installations, config and data files will be stored at the platform default paths, as defined by env-paths.

For backwards compatibility, if the ~/.waveterm or WAVETERM_HOME directory exists and contains valid data, it will be used. If this check fails, then WAVETERM_DATA_HOME and WAVETERM_CONFIG_HOME will be used. If these are not defined, then XDG_DATA_HOME and XDG_CONFIG_HOME will be used. Finally, if none of these are defined, the env-paths defaults will be used.

As with the existing app, dev instances will write to waveterm-dev directories, while all others will write to waveterm.

@CLAassistant
Copy link

CLAassistant commented Oct 16, 2024

CLA assistant check
All committers have signed the CLA.

@esimkowitz esimkowitz marked this pull request as ready for review October 16, 2024 22:45
@esimkowitz esimkowitz linked an issue Oct 17, 2024 that may be closed by this pull request
@esimkowitz esimkowitz changed the title Move default config and data dirs to better align with XDG spec and user expectations Update data and config paths to match platform defaults Oct 18, 2024
@esimkowitz esimkowitz added this to the v0.9.0 milestone Oct 18, 2024
@sawka sawka merged commit 33f05c6 into dev-v0.9 Oct 22, 2024
2 checks passed
@sawka sawka deleted the evan/move-config-0.9 branch October 22, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: move settings under $HOME/.config/waveterm
3 participants