Expose MaxConnsPerNode from AeroSpike to allow easier performance tuning #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
munan-geo
changed the title
amber-ashraf
approved these changes
Aug 13, 2024
brittany-alves
approved these changes
Aug 13, 2024
farmerau
requested changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to expose MaxConnsPerNode from AeroSpike to allow easier performance tuning.
Note 1: We leave
MaxConnsPerNodeas 100 which is the default from Aerospike. However, Aerospike has also updated other default settings, see the change reasons from Aerospike forum. We will update AsyncMaxCommands to 100 when we bump up Aerospike version so we align with Aerospike settings. Also, the relationship between asyncMaxConnsPerNode and MaxConnsPerNode can be found from here.Note 2: We are running into code cov issue and it seems that we didn't have token setup properly for this repo. I was instructed to comment out the code cov temporarily.
Type of Change
Checklist