Skip to content

Commit

Permalink
added embeddings folder but not files inside
Browse files Browse the repository at this point in the history
  • Loading branch information
Chris Antonellis committed Mar 2, 2021
1 parent e66a590 commit b1305ea
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 9 deletions.
6 changes: 2 additions & 4 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ style_venv/
.DS_Store
*.zip

embeddings/glove.840B.300d*

################################
# Bellow is created as described
################################
Expand Down Expand Up @@ -279,5 +277,5 @@ dmypy.json
.venv/

# End of https://www.gitignore.io/api/emacs,python,intellij+all
embeddings
/output/
embeddings/glove*
output/*
14 changes: 13 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,19 @@ Code to run the Extra [algorithm](https://aclanthology.info/papers/D18-1384/d18-
**IMPORTANT**:
1. When running Extra inside docker-container, make sure that Docker process has enough resources.
For example, on Mac/Windows it should have at least 8 Gb of RAM available to it.
1. GitHub repo does **not** come with Glove Embeddings. TODO: update after script is in place.
1. GitHub repo does **not** come with Glove Embeddings. See the next section for how to download the reuired embeddings.

### Downloading Embeddings

**This package does not come with the required Glove embeddings and they must be downloaded before use.**

To download the required embeddings, run the following command:

```bash
docker-compose run --rm setup
```

The embeddings will be downloaded, unzipped and formatted into a space-efficient format. Files will be save in the `embeddings/` directory in the root of the project directory. If the process fails, it can be safely restarted. If you want to restart the process with new files, delete all files except `README.md` in the `embeddings/` directory.

### Using docker-compose

Expand Down
12 changes: 8 additions & 4 deletions docker-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,17 @@ services:
- ./embeddings:/embeddings
- ./io:/io

# download embeddings
setup:
<<: *dev
entrypoint: "extra-model-setup"

# run extra-model
extra-model:
<<: *dev
entrypoint: "extra-model"
command: "--help"

# run all the tests and linting locally
# - black & isort will format code to address issues
# run test & lint suite
test:
<<: *dev
command: docker/run_tests.sh --format-code
command: "docker/run_tests.sh --format-code"
3 changes: 3 additions & 0 deletions embeddings/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# embeddings

This directory exists to contain embeddings resources downloaded by the `extra-model-setup` entrypoint.

0 comments on commit b1305ea

Please sign in to comment.