Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only use opendota #33

Closed
wants to merge 5 commits into from
Closed

Conversation

hsearcy
Copy link

@hsearcy hsearcy commented Dec 15, 2017

Credit to @liboz for the match history piece in #32

Since 7.07 the Dota 2 API hasn't returned ranked matches from history, making this less than useful. @liboz made a change to use the opendota API to get match history. However, I found that I was still getting spotty results for some reason, so I made it pull the players from opendota, too.

This is a potential fix for #31

@liboz
Copy link

liboz commented Dec 15, 2017

Maybe you ought to just remove the need for the steamapikey entirely. There's only 2 more calls one of which is matchdetails, which I believe opendota has as well.

@hsearcy
Copy link
Author

hsearcy commented Dec 15, 2017

I agree, I was just being lazy and didn't want to modify the UI. I might do so later, but for now I built this version on my local machine and am using it with decent results.

@hsearcy
Copy link
Author

hsearcy commented Dec 17, 2017

as per @liboz 's suggestion, I completely removed the steamAPI dependency. Everything seems to be working smoothly now.

@liboz
Copy link

liboz commented Dec 17, 2017

@hsearcy Is there a reason you didn't remove the steam-api package dependence in package.json when recreating the commits I made?

@hsearcy
Copy link
Author

hsearcy commented Dec 18, 2017

@liboz Nope, I was just switching between operating systems so my package.json was getting whacky, so I didn't commit changes to it. I will pull it out of there shortly, but I'm going to try to see if using opendota allows more functionality to be easily added from data already pulled in.

@hsearcy hsearcy closed this Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants