Feature: Support models with specific table_name during migration generation #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In our app we have all models namespaced via sub-domain. The current Hoardable generator assumes the table name by doing some string manipulation on the passed in model.
So, in our case (using a fictional example):
This causes the migration to die when we run it. If we pass in the explicit table name instead of the model, the migration still dies because it cannot resolve back to the model when it tries to work out the primary key type (we use uuid).
It's perhaps nicer to actually consult the model itself to work out what the correct table name is. That's what this PR does.
Happy to discuss it further if you have some other ideas!