Unskip several tests #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kertal
commented
Dec 29, 2023
Comment on lines
+95
to
+98
| ], | ||
| [ | ||
| "order_id", | ||
| "desc" |
There was a problem hiding this comment.
@wayneseymour with this change the sort order is now stable, however, it's different than before, so snapshots had to be re-generated
wayneseymour
approved these changes
Dec 29, 2023
|
/ci |
wayneseymour
merged commit 88ee17d
into
wayneseymour:esarch-fixed-higher-watermark-impl-minimal-code-chages-without-benchmark-tool
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR unskips several tests broken due to concurrent ingestion, causing problems with sorting when timestamps were the same. I've added another field to sort by (order_id) to fix this, and the snapshot tests then had to be fixed.
Checklist