Navmenu/footer #12
Merged
Navmenu/footer #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the code for the new header that we are planning on having. There is still some work to do, such as maybe add a search bar on the far right, and I know I gotta tidy up the code a little bit, but for now, this works. The color scheme might need some work, so we may need to revise that.
This is the updated header and footer design that we are planning on using for the site. This is just the basic design just so we can at least have a header and a footer. This is not mobile-responsive so we will have to make that mobile responsive, as well as revise the color scheme of course. And, Oliver also brought up a mis-alignment in the footer columns, so they will have to fix that as well(though it may not be necessary).
sempiternael
approved these changes
Mar 9, 2020
|
Please clean up your class names. They are needlessly complicated. Approved for merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the header and footer that we are planning on using for the site. This is just the basic design, just to get started, and it is definitely not final. We have to start merging this into the master branch, if I know github correctly, sooo yeah.