Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Service Edits #1097

Merged
merged 142 commits into from
Apr 3, 2024
Merged

feat: Service Edits #1097

merged 142 commits into from
Apr 3, 2024

Conversation

JoeKarow
Copy link
Member

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: IN-945

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

Copy link

vercel bot commented Feb 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
inreach-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2024 6:57pm

@JoeKarow JoeKarow marked this pull request as draft February 13, 2024 22:58
@JoeKarow JoeKarow added the new-feature New features or options. label Feb 13, 2024
Copy link
Contributor

github-actions bot commented Feb 13, 2024

📦 Next.js Bundle Analysis for @weareinreach/app

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Four Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (575 KB)
/org/[slug] 319.69 KB 721.88 KB 125.54% (🟡 +0.77%)
/org/[slug]/[orgLocationId] 314.19 KB 716.38 KB 124.59% (🟡 +0.76%)
/org/[slug]/[orgLocationId]/edit 314.6 KB 716.79 KB 124.66% (🟡 +0.63%)
/org/[slug]/remote 275.55 KB 677.75 KB 117.87% (🟡 +1.24%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link

alwaysmeticulous bot commented Feb 13, 2024

🤖 No test run has been triggered as your Meticulous project has been deactivated (since you haven't viewed any test results in a while). Click here to reactivate.

Last updated for commit f4aeb24. This comment will update as new commits are pushed.

@JoeKarow JoeKarow marked this pull request as ready for review April 3, 2024 18:54
Copy link

sonarcloud bot commented Apr 3, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
4 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.7% Duplication on New Code

See analysis details on SonarCloud

@weareinreach weareinreach deleted a comment Apr 3, 2024
@kodiakhq kodiakhq bot merged commit 95a2e05 into dev Apr 3, 2024
32 of 33 checks passed
@kodiakhq kodiakhq bot deleted the IN-945-service-edit-page branch April 3, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants