-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update Marker type from Google Maps API #1159
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
📦 ui
automerge
Enable Kodiak auto-merge
kodiak: merge.method = 'squash'
Kodiak will squash merge this PR.
labels
Mar 17, 2024
📦 Next.js Bundle Analysis for @weareinreach/appThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
russchristina
changed the title
Transition to using new Marker type from Google Maps API
Update Marker type from Google Maps API
Mar 17, 2024
russchristina
changed the title
Update Marker type from Google Maps API
[improve] Update Marker type from Google Maps API
Mar 17, 2024
russchristina
changed the title
[improve] Update Marker type from Google Maps API
chore: Update Marker type from Google Maps API
Mar 17, 2024
Quality Gate passedIssues Measures |
JoeKarow
approved these changes
Mar 18, 2024
JoeKarow
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automerge
Enable Kodiak auto-merge
kodiak: merge.method = 'squash'
Kodiak will squash merge this PR.
maintenance
Generic maintenance tasks.
📦 ui
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR slightly refactors a bit of the UI-related code to use the new Marker type from the Google Maps API. The new Marker type has a slightly different implementation from its predecessor; it uses properties where its predecessor used methods instead, so my changes reflect this difference.
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
No behavior should be modified. The use of new Marker type shouldn't change the behavior. It just uses Google Maps API's new implementation for the Marker.
Issue Number: 947
What is the new behavior?
There is no new behavior as stated above.
Does this introduce a breaking change?
Other information