Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Marker type from Google Maps API #1159

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Conversation

russchristina
Copy link
Contributor

@russchristina russchristina commented Mar 17, 2024

This small PR slightly refactors a bit of the UI-related code to use the new Marker type from the Google Maps API. The new Marker type has a slightly different implementation from its predecessor; it uses properties where its predecessor used methods instead, so my changes reflect this difference.

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe): General maintenance

What is the current behavior?

No behavior should be modified. The use of new Marker type shouldn't change the behavior. It just uses Google Maps API's new implementation for the Marker.

Issue Number: 947

What is the new behavior?

There is no new behavior as stated above.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Copy link

alwaysmeticulous bot commented Mar 17, 2024

🤖 No test run has been triggered as your Meticulous project has been deactivated (since you haven't viewed any test results in a while). Click here to reactivate.

Last updated for commit 27ae56b. This comment will update as new commits are pushed.

Copy link

vercel bot commented Mar 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
inreach-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2024 2:51pm

@github-actions github-actions bot added 📦 ui automerge Enable Kodiak auto-merge kodiak: merge.method = 'squash' Kodiak will squash merge this PR. labels Mar 17, 2024
Copy link
Contributor

github-actions bot commented Mar 17, 2024

📦 Next.js Bundle Analysis for @weareinreach/app

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@russchristina russchristina added the maintenance Generic maintenance tasks. label Mar 17, 2024
@russchristina russchristina changed the title Transition to using new Marker type from Google Maps API Update Marker type from Google Maps API Mar 17, 2024
@russchristina russchristina changed the title Update Marker type from Google Maps API [improve] Update Marker type from Google Maps API Mar 17, 2024
@russchristina russchristina changed the title [improve] Update Marker type from Google Maps API chore: Update Marker type from Google Maps API Mar 17, 2024
@russchristina russchristina marked this pull request as ready for review March 17, 2024 17:34
Copy link

sonarcloud bot commented Mar 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kodiakhq kodiakhq bot merged commit 762856b into dev Mar 18, 2024
24 checks passed
@kodiakhq kodiakhq bot deleted the IN-947-google-maps-marker branch March 18, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Enable Kodiak auto-merge kodiak: merge.method = 'squash' Kodiak will squash merge this PR. maintenance Generic maintenance tasks. 📦 ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants