fix: Visit/Contact card conditional rendering

[JoeKarow]

Pull Request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no API changes)
• Build-related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• New Features

  • Added display of operational hours in the visit card if available.

• Bug Fixes

  • Improved contact information logic to accurately reflect the presence of contact details.

• Enhancements

  • Enhanced ContactSection and VisitCard components to better handle the absence of key data, improving user experience.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
inreach-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 18, 2024 7:18pm

[coderabbitai]

Walkthrough

The recent updates introduce improved data handling and conditional rendering logic across the codebase. Specifically, they enhance the forVisitCard function to include operational hours data, adjust the contact information query to be more precise, and refine the display logic in UI components to better handle cases where certain data is missing. These changes ensure more accurate data representation and improve overall code readability and maintainability.

Changes

Files	Change Summary
packages/api/router/location/query.forVisitCard.handler.ts	Added hours property and a check for its existence to set hasHours accordingly.
packages/api/router/misc/query.hasContactInfo.handler.ts	Modified whereId function to use some for locations, and adjusted hasContactInfo to calculate totalCount correctly.
packages/ui/components/sections/ContactSection/index.tsx	Updated logic to return null if hasContactInfo and edit are both falsy.
packages/ui/components/sections/VisitCard.tsx	Added conditional check to return null if both formattedAddress and data.hasHours are falsy.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[relativeci]

#962 Bundle Size — 3.5MiB (~+0.01%).

ad1046b(current) vs 42c8127 dev#957(baseline)

Warning

Bundle contains 5 duplicate packages – View duplicate packages

Bundle metrics   1 change 1 regression

	Current #962	Baseline #957
Initial JS	3.07MiB(~+0.01%)	3.07MiB
Initial CSS	9.54KiB	9.54KiB
Cache Invalidation	44.85%	44.85%
Chunks	64	64
Assets	77	77
Modules	2054	2054
Duplicate Modules	340	340
Duplicate Code	9.42%	9.42%
Packages	208	208
Duplicate Packages	5	5

Bundle size by type   1 change 1 regression

	Current #962	Baseline #957
JS	3.38MiB (~+0.01%)	3.38MiB
Fonts	94.54KiB	94.54KiB
CSS	9.54KiB	9.54KiB
Other	9.09KiB	9.09KiB
IMG	8.57KiB	8.57KiB

---

Bundle analysis report Branch JoeKarow/visit-card-fix Project dashboard

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ee20a26 and ad1046b.

Files selected for processing (4)

• packages/api/router/location/query.forVisitCard.handler.ts (1 hunks)
• packages/api/router/misc/query.hasContactInfo.handler.ts (2 hunks)
• packages/ui/components/sections/ContactSection/index.tsx (1 hunks)
• packages/ui/components/sections/VisitCard.tsx (1 hunks)

Additional comments not posted (6)

packages/ui/components/sections/ContactSection/index.tsx (1)

13-15: Good use of conditional rendering to avoid unnecessary rendering.

The added conditional block improves readability and maintainability by explicitly handling the case where there is no contact information and the component is not in edit mode.

packages/api/router/location/query.forVisitCard.handler.ts (2)

32-32: Addition of hours property in the data fetch.

The inclusion of the hours property ensures that operational hours data is fetched from the database, which is essential for accurate data representation.

---

38-44: Proper handling of hours data.

The check for the existence of hours and the setting of hasHours based on this condition ensure that the function can properly handle cases where operational hours data is available.

packages/api/router/misc/query.hasContactInfo.handler.ts (2)

77-78: Improvement in contact information query.

The change from every to some for socialMedia and website properties ensures that the function correctly identifies cases where at least one social media or website entry exists for the given input.

---

123-126: Accurate calculation of contact information count.

The calculation of totalCount before returning the result ensures that the function accurately reflects the presence of contact information by summing up the counts of email, phone, social media, and website entries.

packages/ui/components/sections/VisitCard.tsx (1)

112-114: Effective conditional rendering to avoid incomplete display.

The added conditional check ensures that the component does not render if there is no address and no operational hours data, improving the rendering logic by avoiding the display of incomplete or irrelevant information.

[github-actions]

📦 Next.js Bundle Analysis for @weareinreach/app

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

[alwaysmeticulous]

🤖 No test run has been triggered as your Meticulous project has been deactivated (since you haven't viewed any test results in a while). Click here to reactivate.

_{Last updated for commit ad1046b. This comment will update as new commits are pushed.}