Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): adjust badge level to avoid link to org page in search results #690

Merged
merged 3 commits into from
Aug 1, 2023
Merged

fix(ui): adjust badge level to avoid link to org page in search results #690

merged 3 commits into from
Aug 1, 2023

Conversation

kyle-pazdel
Copy link
Collaborator

@kyle-pazdel kyle-pazdel commented Jul 31, 2023 •
edited by JoeKarow
Loading

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: PLI-36

What is the new behavior?

  • The BadgeGroup component is now rendered outside of the Link component in the Title on the SearchResultCard
  • This will enable mobile users to tap on the icon to read its title without unintentionally moving to the Org's info page

Does this introduce a breaking change?

  • Yes
  • No

Other information

@vercel
Copy link

vercel bot commented Jul 31, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
inreach-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2023 6:29pm

@ghost
Copy link

ghost commented Jul 31, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

JoeKarow and others added 2 commits August 1, 2023 14:25
@JoeKarow JoeKarow added bugfix Inconsistencies or issues which will cause a problem for users or implementors. automerge Enable Kodiak auto-merge labels Aug 1, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JoeKarow JoeKarow changed the title adjusts badge level to avoid link to org page in search results fix(ui): adjust badge level to avoid link to org page in search results Aug 1, 2023
@JoeKarow JoeKarow marked this pull request as ready for review August 1, 2023 18:35
@kodiakhq kodiakhq bot merged commit ab85f30 into dev Aug 1, 2023
26 of 29 checks passed
@kodiakhq kodiakhq bot deleted the PLI-36-hover-text-on-search-results-page-doesnt-work-as-expected-on-mobile branch August 1, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeKarow JoeKarow JoeKarow approved these changes

Assignees
No one assigned
Labels
automerge Enable Kodiak auto-merge bugfix Inconsistencies or issues which will cause a problem for users or implementors. 📦 ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyle-pazdel @JoeKarow