Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: password reset & review add #743

Merged
merged 7 commits into from
Aug 28, 2023
Merged

fix: password reset & review add #743

merged 7 commits into from
Aug 28, 2023

Conversation

JoeKarow
Copy link
Member

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: IN-917 IN-918

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@vercel
Copy link

vercel bot commented Aug 28, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
inreach-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2023 11:27pm

@ghost
Copy link

ghost commented Aug 28, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Aug 28, 2023 •
edited
Loading

✅ Meticulous spotted zero visual differences across 160 screens tested: view results.

Last updated for commit 6a0d3d1. This comment will update as new commits are pushed.

@JoeKarow JoeKarow added bugfix Inconsistencies or issues which will cause a problem for users or implementors. automerge Enable Kodiak auto-merge labels Aug 28, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JoeKarow JoeKarow marked this pull request as ready for review August 28, 2023 23:30
@JoeKarow JoeKarow requested review from InReach-svc and removed request for InReach-svc August 28, 2023 23:30
@JoeKarow JoeKarow merged commit 1f7af7b into dev Aug 28, 2023
16 checks passed
@JoeKarow JoeKarow deleted the IN-917-password-reset-500-error branch August 28, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@InReach-svc InReach-svc InReach-svc approved these changes

Assignees
No one assigned
Labels
📦 api 📦 app 📦 auth automerge Enable Kodiak auto-merge bugfix Inconsistencies or issues which will cause a problem for users or implementors. 📦 config 📦 db 📦 env 📦 eslint-config 📦 ui 📦 util
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoeKarow @InReach-svc