Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: review count display for location #744

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Conversation

JoeKarow
Copy link
Member

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

On a location page, the review count was showing the org total.

Issue Number: IN-919

What is the new behavior?

  • Review count is now accurate

Does this introduce a breaking change?

  • Yes
  • No

Other information

@vercel
Copy link

vercel bot commented Aug 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
inreach-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2023 3:28pm

@JoeKarow JoeKarow added bugfix Inconsistencies or issues which will cause a problem for users or implementors. automerge Enable Kodiak auto-merge labels Aug 29, 2023
@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Aug 29, 2023

🤖 Meticulous replayed 50 user sessions and took 160 screenshots. Meticulous has not yet run on 7ca3366 of the main branch and so there was nothing to compare against.

If you recently setup Meticulous, this is expected. Meticulous will start reporting comparisons for new pull requests after the next commit to the main branch.

Last updated for commit 6d4328f. This comment will update as new commits are pushed.

@sonarcloud
Copy link

sonarcloud bot commented Aug 29, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@ghost
Copy link

ghost commented Aug 29, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@kodiakhq kodiakhq bot merged commit 9d0e6f8 into dev Aug 29, 2023
14 of 16 checks passed
@kodiakhq kodiakhq bot deleted the IN-919-review-count-inaccurate branch August 29, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Enable Kodiak auto-merge bugfix Inconsistencies or issues which will cause a problem for users or implementors. 📦 ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants