Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unauthed review click should show login modal #771

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

JoeKarow
Copy link
Member

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

When not logged in, clicking the "Review" button on an org page would open the review composition modal. User must be logged in to leave a review.

Issue Number: PLI-32

What is the new behavior?

Login prompt modal now shows when not auth'd.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@vercel
Copy link

vercel bot commented Sep 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
inreach-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2023 6:00pm

@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ghost
Copy link

ghost commented Sep 15, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@JoeKarow JoeKarow added bugfix Inconsistencies or issues which will cause a problem for users or implementors. automerge Enable Kodiak auto-merge labels Sep 15, 2023
@kodiakhq kodiakhq bot merged commit 4872481 into dev Sep 15, 2023
21 of 23 checks passed
@kodiakhq kodiakhq bot deleted the PLI-32-reviews-non-logged-in-click branch September 15, 2023 18:00
@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Sep 15, 2023

🤖 Meticulous spotted visual differences in 7 of 202 screens tested: view and approve differences detected.

Last updated for commit e2a9751. This comment will update as new commits are pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Enable Kodiak auto-merge bugfix Inconsistencies or issues which will cause a problem for users or implementors. 📦 ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants