Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: service category nesting, new category #773

Merged
merged 19 commits into from
Sep 18, 2023

Conversation

JoeKarow
Copy link
Member

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: IN-925

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@vercel
Copy link

vercel bot commented Sep 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
inreach-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2023 7:02pm

@ghost
Copy link

ghost commented Sep 15, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Sep 15, 2023

🤖 Meticulous replayed 50 user sessions and took 197 visual snapshots. Meticulous has not yet run on 2e093b1 of the main branch and so there was nothing to compare against.

If you recently setup Meticulous, this is expected. Meticulous will start reporting comparisons for new pull requests after the next commit to the main branch.

Last updated for commit 1374ab9. This comment will update as new commits are pushed.

@JoeKarow JoeKarow added automerge Enable Kodiak auto-merge new-feature New features or options. maintenance Generic maintenance tasks. labels Sep 18, 2023
Signed-off-by: InReach [bot] <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Sep 18, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
30.2% 30.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@JoeKarow JoeKarow marked this pull request as ready for review September 18, 2023 19:01
@JoeKarow JoeKarow added the dependencies Change in project dependencies. label Sep 18, 2023
@kodiakhq kodiakhq bot merged commit ed0fd08 into dev Sep 18, 2023
10 of 11 checks passed
@kodiakhq kodiakhq bot deleted the IN-925-new-service-categories branch September 18, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 api 📦 app automerge Enable Kodiak auto-merge 📦 db dependencies Change in project dependencies. maintenance Generic maintenance tasks. new-feature New features or options. 📦 ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants