Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alert messages #939

Merged
merged 2 commits into from
Dec 5, 2023
Merged

fix: alert messages #939

merged 2 commits into from
Dec 5, 2023

Conversation

JoeKarow
Copy link
Member

@JoeKarow JoeKarow commented Dec 5, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe): data migration

What is the current behavior?

Alert messages weren't respecting the "active" flag on attributeSupplements.

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

Copy link

vercel bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
inreach-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2023 4:13pm

Copy link

sonarcloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JoeKarow JoeKarow added bugfix Inconsistencies or issues which will cause a problem for users or implementors. automerge Enable Kodiak auto-merge maintenance Generic maintenance tasks. kodiak: merge.method = 'squash' Kodiak will squash merge this PR. labels Dec 5, 2023
@ghost
Copy link

ghost commented Dec 5, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Contributor

github-actions bot commented Dec 5, 2023

📦 Next.js Bundle Analysis for @weareinreach/app

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 412.07 KB (🟡 +1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@kodiakhq kodiakhq bot merged commit 51b3682 into dev Dec 5, 2023
35 of 37 checks passed
@kodiakhq kodiakhq bot deleted the JoeKarow/alert-msg branch December 5, 2023 16:13
Copy link

alwaysmeticulous bot commented Dec 5, 2023

✅ Meticulous spotted zero visual differences across 218 screens tested: view results.

Last updated for commit af1fcb1. This comment will update as new commits are pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 api automerge Enable Kodiak auto-merge bugfix Inconsistencies or issues which will cause a problem for users or implementors. 📦 db kodiak: merge.method = 'squash' Kodiak will squash merge this PR. maintenance Generic maintenance tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants