Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: schema updates #953

Merged
merged 4 commits into from
Dec 11, 2023
Merged

fix: schema updates #953

merged 4 commits into from
Dec 11, 2023

Conversation

JoeKarow
Copy link
Member

  • cherry-pick migration from IN-831-edit-organization-page
  • update bool defaults

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

OrgLocation api query was excluding results due to boolean value allowed to be null.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Copy link

vercel bot commented Dec 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
inreach-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2023 9:50pm

@JoeKarow JoeKarow added bugfix Inconsistencies or issues which will cause a problem for users or implementors. automerge Enable Kodiak auto-merge labels Dec 11, 2023
@ghost
Copy link

ghost commented Dec 11, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Contributor

github-actions bot commented Dec 11, 2023

📦 Next.js Bundle Analysis for @weareinreach/app

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (575 KB)
/org/[slug] 94.17 KB 507.57 KB 88.27% (🟡 +0.02%)
/org/[slug]/[orgLocationId] 88.79 KB 502.19 KB 87.34% (🟡 +0.02%)
/org/[slug]/[orgLocationId]/edit 88.3 KB 501.7 KB 87.25% (🟡 +0.02%)
/org/[slug]/edit 93.42 KB 506.83 KB 88.14% (🟡 +0.02%)
/org/[slug]/remote 70.63 KB 484.03 KB 84.18% (🟡 +0.02%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link

alwaysmeticulous bot commented Dec 11, 2023

✅ Meticulous spotted zero visual differences across 220 screens tested: view results.

Last updated for commit d0ab4d7. This comment will update as new commits are pushed.

Copy link

sonarcloud bot commented Dec 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kodiakhq kodiakhq bot merged commit 6bc0499 into dev Dec 11, 2023
24 checks passed
@kodiakhq kodiakhq bot deleted the JoeKarow/schema-update branch December 11, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 api automerge Enable Kodiak auto-merge bugfix Inconsistencies or issues which will cause a problem for users or implementors. 📦 db 📦 ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants