Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GAUGE_CALC_TOTAL should be 'sum' and not 'total' #614

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

davaffy
Copy link
Contributor

@davaffy davaffy commented Aug 1, 2023

What does this do?

Correct wrong literal value for total values

Why is it a good idea?

It's better that the users use the literals defined by grafanalib instead of their own so that future changes are autmatically adopted.

Context

#540 is corrected with this.

Questions

None

Copy link
Collaborator

@JamesGibo JamesGibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot, thanks for the PR

@JamesGibo JamesGibo merged commit 1fa5421 into weaveworks:main Aug 18, 2023
5 checks passed
@davaffy davaffy deleted the fix/total_literal_to_sum branch August 31, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants