-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Main improved dashboard links #622
Merged
JamesGibo
merged 9 commits into
weaveworks:main
from
Zensor-BE:main-improved-dashboard-links
Sep 29, 2023
Merged
Main improved dashboard links #622
JamesGibo
merged 9 commits into
weaveworks:main
from
Zensor-BE:main-improved-dashboard-links
Sep 29, 2023
Commits on Sep 28, 2023
-
Add missing options, functionality to DashboardLink
Includes the ability to create direct links or a list of dashboard links, extra options like includeVars and targetBlank.
Configuration menu - View commit details
-
Copy full SHA for d30b98a - Browse repository at this point
Copy the full SHA d30b98aView commit details -
Add docstring to DashboardLink, remove the unused
dashboard
paramRemoving this parameter is a breaking change... It didn't actually impact the generated link, other than acting as an alias to 'title' in some cases. If preferred, I can restore it to retain that alias behaviour, and perhaps add a warning log message?
Configuration menu - View commit details
-
Copy full SHA for 88a6e4b - Browse repository at this point
Copy the full SHA 88a6e4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for bc8fe56 - Browse repository at this point
Copy the full SHA bc8fe56View commit details -
Configuration menu - View commit details
-
Copy full SHA for 412d8db - Browse repository at this point
Copy the full SHA 412d8dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for cdda04e - Browse repository at this point
Copy the full SHA cdda04eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c949a8b - Browse repository at this point
Copy the full SHA c949a8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4424611 - Browse repository at this point
Copy the full SHA 4424611View commit details -
Configuration menu - View commit details
-
Copy full SHA for d13d4bb - Browse repository at this point
Copy the full SHA d13d4bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for fb44dd6 - Browse repository at this point
Copy the full SHA fb44dd6View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.