Implement update profile to patch a profile's HelmRelease
#1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 14, 2022 19:25
- Add cobra CLI command func and required flags - Refactor Add Profile func to re-use some functionality for Update Profile - Add acceptance test
- Refactor profiles funcs to fail if profiles.yaml contains no HelmReleases - Refactor func that appends HelmRelease to file so that update fails if HelmRelease does not exist
nikimanoledaki
changed the title
update profile to patch a profile's HelmReleaseupdate profile to patch a profile's HelmRelease
nikimanoledaki
added
type/enhancement
nikimanoledaki
force-pushed
the
update-profile
branch
from
a3ebaf6
to
39e2b04
Compare
nikimanoledaki
changed the title
update profile to patch a profile's HelmReleaseupdate profile to patch a profile's HelmRelease
nikimanoledaki
requested review from
aclevername,
Skarlso,
cPu1 and
Himangini
nikimanoledaki
force-pushed
the
update-profile
branch
from
39e2b04
to
62de952
Compare
aclevername
reviewed
Feb 15, 2022
aclevername
reviewed
Feb 15, 2022
aclevername
reviewed
Feb 15, 2022
aclevername
reviewed
Feb 15, 2022
aclevername
reviewed
Feb 15, 2022
aclevername
reviewed
Feb 15, 2022
nikimanoledaki
force-pushed
the
update-profile
branch
from
67be697
to
5860e00
Compare
nikimanoledaki
force-pushed
the
update-profile
branch
from
5860e00
to
90d5840
Compare
aclevername
reviewed
Feb 15, 2022
nikimanoledaki
force-pushed
the
update-profile
branch
from
90d5840
to
ff9b92e
Compare
aclevername
reviewed
Feb 15, 2022
aclevername
approved these changes
Feb 15, 2022
nikimanoledaki
force-pushed
the
update-profile
branch
from
ff9b92e
to
cd0746d
Compare
Skarlso
reviewed
Feb 16, 2022
Skarlso
reviewed
Feb 16, 2022
pkg/helm/releases.go
Outdated
| @@ -37,3 +43,58 @@ func MakeHelmRelease(name, version, cluster, namespace string, helmRepository ty | |||
| }, | |||
| } | |||
| } | |||
|
|
|||
| // AppendHelmReleaseToString appends a HelmRelease to a string. | |||
There was a problem hiding this comment.
:D Can you be a tiny bit more descriptive please? :) Why? How? What's the purpose of the append?
Skarlso
reviewed
Feb 16, 2022
Skarlso
reviewed
Feb 16, 2022
Skarlso
reviewed
Feb 16, 2022
nikimanoledaki
force-pushed
the
update-profile
branch
from
e54bb98
to
28a502e
Compare
…n app with long name'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1138
What changed?
This PR implements
gitops update profile.Why?
Minimum/required flags:
gitops update profile --name=podinfo --cluster=prod --config-repo=ssh://[email protected]/owner/config-repo.git --version=6.0.0Optional flags:
--namespacedefaults towego-system--versiondefaults tolatest--profiles-portfor the Profiles API port--auto-merge--kubeconfigImplementation Notes
add profileto reuse some of its functionality.HelmReleases(separated by---) directly into a list ofHelmReleases, rather than[][]bytes.strings.Builderto append the new and existingHelmReleases as a string to write theprofiles.yamlfile's content.How did you test it?
Install
gitopson a local kind cluster. Then, add a profile to the cluster:Wait for the pod to appear in the cluster. Wait for ~5 minutes (likely because the Github API caches the results). Then update the profile installation's version:
Example PR: https://github.com/nikimanoledaki/fun-times/pull/22
Release notes
Documentation Changes