Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/types as string #58

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Bug/types as string #58

merged 2 commits into from
Jul 26, 2023

Conversation

Spomky
Copy link
Contributor

@Spomky Spomky commented Jul 26, 2023

Target branch:
Resolves issue #

  • It is a Bug fix
  • It is a New feature
  • Breaks BC
  • Includes Deprecations

@Spomky Spomky added the bug Something isn't working label Jul 26, 2023
@Spomky Spomky added this to the 4.2.2 milestone Jul 26, 2023
@Spomky Spomky self-assigned this Jul 26, 2023
@Spomky Spomky linked an issue Jul 26, 2023 that may be closed by this pull request
@Spomky Spomky changed the base branch from 4.3.x to 4.2.x July 26, 2023 12:14
@Spomky Spomky merged commit 269f22d into 4.2.x Jul 26, 2023
@Spomky Spomky deleted the bug/types-as-string branch July 26, 2023 12:21
Spomky added a commit that referenced this pull request Jul 26, 2023
* EC2Key and OkpKey class now supports curves as strings (#56)

EC2Key and OkpKey class now supports curves as strings

* Bug/types as string (#58)

Key type can be of type string

---------

Co-authored-by: Florent Morselli <[email protected]>
Spomky added a commit that referenced this pull request Jul 26, 2023
* EC2Key and OkpKey class now supports curves as strings (#56)

EC2Key and OkpKey class now supports curves as strings

* Bug/types as string (#58)

Key type can be of type string

* Fix bad curve (#60)

---------

Co-authored-by: Florent Morselli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check of key type and curve assume value is int
1 participant