Skip to content

Commit

Permalink
Refactor code for deprecation of "id" property
Browse files Browse the repository at this point in the history
The "id" property in the PublicKeyCredential is deprecated. This commit refactors the relevant code, specifically in the "PublicKeyCredential" class and several test classes, to replace the use of "Base64UrlSafe::decode($publicKeyCredential->id)" with "$publicKeyCredential->rawId". The changes are made such that the functionality is maintained but future compatibility is ensured.
  • Loading branch information
Spomky committed Jun 15, 2024
1 parent 543e6af commit 6c917ae
Showing 1 changed file with 13 additions and 13 deletions.
26 changes: 13 additions & 13 deletions phpstan-baseline.neon
Original file line number Diff line number Diff line change
Expand Up @@ -850,16 +850,6 @@ parameters:
count: 1
path: src/symfony/src/DataCollector/WebauthnCollector.php

-
message: "#^Call to an undefined method Symfony\\\\Component\\\\Config\\\\Definition\\\\Builder\\\\NodeParentInterface\\:\\:integerNode\\(\\)\\.$#"
count: 2
path: src/symfony/src/DependencyInjection/Configuration.php

-
message: "#^Call to an undefined method Symfony\\\\Component\\\\Config\\\\Definition\\\\Builder\\\\NodeParentInterface\\:\\:scalarNode\\(\\)\\.$#"
count: 4
path: src/symfony/src/DependencyInjection/Configuration.php

-
message: """
#^Call to deprecated method addAndroidSafetynetConfig\\(\\) of class Webauthn\\\\Bundle\\\\DependencyInjection\\\\Configuration\\:
Expand All @@ -869,9 +859,14 @@ parameters:
path: src/symfony/src/DependencyInjection/Configuration.php

-
message: "#^Call to an undefined method Symfony\\\\Component\\\\Config\\\\Definition\\\\Builder\\\\NodeParentInterface\\:\\:scalarNode\\(\\)\\.$#"
count: 1
path: src/symfony/src/DependencyInjection/Factory/Security/WebauthnFactory.php
message: "#^Cannot call method integerNode\\(\\) on Symfony\\\\Component\\\\Config\\\\Definition\\\\Builder\\\\NodeParentInterface\\|null\\.$#"
count: 2
path: src/symfony/src/DependencyInjection/Configuration.php

-
message: "#^Cannot call method scalarNode\\(\\) on Symfony\\\\Component\\\\Config\\\\Definition\\\\Builder\\\\NodeParentInterface\\|null\\.$#"
count: 4
path: src/symfony/src/DependencyInjection/Configuration.php

-
message: "#^Cannot access offset 'enabled' on mixed\\.$#"
Expand Down Expand Up @@ -913,6 +908,11 @@ parameters:
count: 12
path: src/symfony/src/DependencyInjection/Factory/Security/WebauthnFactory.php

-
message: "#^Cannot call method scalarNode\\(\\) on Symfony\\\\Component\\\\Config\\\\Definition\\\\Builder\\\\NodeParentInterface\\|null\\.$#"
count: 1
path: src/symfony/src/DependencyInjection/Factory/Security/WebauthnFactory.php

-
message: "#^Method Webauthn\\\\Bundle\\\\DependencyInjection\\\\Factory\\\\Security\\\\WebauthnFactory\\:\\:createAuthenticator\\(\\) never returns array\\<string\\> so it can be removed from the return type\\.$#"
count: 1
Expand Down

0 comments on commit 6c917ae

Please sign in to comment.