Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: optimize UI for assets report page #3902

Merged
merged 2 commits into from
Nov 5, 2024
Merged

feat: optimize UI for assets report page #3902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e809e1b
feat: optimize UI for assets report page
chenjiahan Nov 5, 2024
dfb1592
test
chenjiahan Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions e2e/cases/server/viewing-served-files/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ rspackOnlyTest(
const titles = await page.$$eval('h1', (nodes) =>
nodes.map((n) => n.textContent),
);
expect(titles.includes('Assets Report:')).toBe(true);
expect(titles.includes('Assets Report')).toBe(true);

// check all href are valid
const hrefList = await page.$$eval('ul li a', (nodes) =>
Expand Down Expand Up @@ -61,7 +61,7 @@ rspackOnlyTest(
const titles = await page.$$eval('h1', (nodes) =>
nodes.map((n) => n.textContent),
);
expect(titles.includes('Assets Report:')).toBe(true);
expect(titles.includes('Assets Report')).toBe(true);

// check all href are valid
const hrefList = await page.$$eval('ul li a', (nodes) =>
Expand Down Expand Up @@ -118,9 +118,9 @@ rspackOnlyTest(
const subTitles = await page.$$eval('h2', (nodes) =>
nodes.map((n) => n.textContent),
);
expect(titles.includes('Assets Report:')).toBe(true);
expect(subTitles.includes('Compilation: test1')).toBe(true);
expect(subTitles.includes('Compilation: test2')).toBe(true);
expect(titles.includes('Assets Report')).toBe(true);
expect(subTitles.includes('Environment: test1')).toBe(true);
expect(subTitles.includes('Environment: test2')).toBe(true);

// check all href are valid
const hrefList = await page.$$eval('ul li a', (nodes) =>
Expand Down
46 changes: 44 additions & 2 deletions packages/core/src/server/middlewares.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,12 +260,54 @@ export const viewingServedFilesMiddleware: (params: {
if (pathname === '/rsbuild-dev-server') {
res.writeHead(200, { 'Content-Type': 'text/html; charset=utf-8' });
res.write(
'<!DOCTYPE html><html><head><meta charset="utf-8"/></head><body><h1>Assets Report:</h1>',
`<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8"/>
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<style>
body {
margin: 0;
color: #f6f7f9;
padding: 32px 40px;
line-height: 1.8;
min-height: 100vh;
background-image: linear-gradient(#020917, #101725);
font-family: ui-sans-serif,system-ui,sans-serif;
}
h1, h2 {
font-weight: 500;
}
h1 {
margin: 0;
font-size: 36px;
}
h2 {
font-size: 20px;
margin: 24px 0 16px;
}
ul {
margin: 0;
padding-left: 16px;
}
a {
color: #58c4dc;
text-decoration: none;
}
a:hover {
text-decoration: underline;
}
</style>
</head>
<body>
<h1>Assets Report</h1>
</body>
</html>`,
);
try {
for (const key in environments) {
const list = [];
res.write(`<h2>Compilation: ${key}</h2>`);
res.write(`<h2>Environment: ${key}</h2>`);
const environment = environments[key];
const stats = await environment.getStats();
const statsForPrint = stats.toJson();
Expand Down
Loading