fix: expriments.backCompat problem (#749)

e2e/cases/doctor-webpack/experiments.test.ts

@@ -0,0 +1,37 @@
+import { expect, test } from '@playwright/test';
+import { getSDK } from '@rsdoctor/core/plugins';
+import path from 'path';
+import { compileByWebpack5 } from '@scripts/test-helper';
+import { createRsdoctorPlugin } from './test-utils';
+
+async function webpack(compile: typeof compileByWebpack5) {
+  const file = path.resolve(__dirname, './fixtures/b.js');
+  const loader = path.resolve(__dirname, './fixtures/loaders/comment.js');
+  const res = await compile(file, {
+    module: {
+      rules: [
+        {
+          test: /\.js/,
+          use: loader,
+        },
+      ],
+    },
+    experiments: {
+      backCompat: false,
+    },
+    optimization: {
+      minimize: true,
+    },
+    plugins: [createRsdoctorPlugin({})],
+  });
+  return res;
+}
+
+test('webpack5', async () => {
+  await webpack(compileByWebpack5);
+  const sdk = getSDK();
+  const { configs } = sdk.getStoreData();
+
+  expect(configs[0]).toBeInstanceOf(Object);
+  expect(configs[0].name).toEqual('webpack');
+});

e2e/package.json

@@ -3,7 +3,8 @@
   "name": "@rsdoctor/e2e",
   "version": "0.0.1",
   "scripts": {
-    "test": "playwright test"
+    "test": "playwright test",
+    "test:local": "npx playwright install chromium && playwright test"
   },
   "dependencies": {
     "devcert": "1.2.2",

packages/core/src/build-utils/build/utils/plugin.ts

@@ -7,18 +7,18 @@ export type IHook =
 
 export function shouldInterceptPluginHook<T extends IHook>(hook: T) {
   // webpack5 use fakehook for deprecated hook.
-  if ((hook as Common.PlainObject)._fakeHook) {
+  if (hook && (hook as Common.PlainObject)._fakeHook) {
     return false;
   }
 
   // Hook
-  if (typeof hook.isUsed === 'function') {
+  if (hook?.isUsed && typeof hook.isUsed === 'function') {
     return hook.isUsed();
   }
 
   // HookMap
   if (
-    (hook as Common.PlainObject)._map &&
+    (hook as Common.PlainObject)?._map &&
     ((hook as Common.PlainObject)._map as Map<string, unknown>).size === 0
   ) {
     return false;

packages/core/src/inner-plugins/utils/plugin.ts

@@ -40,7 +40,7 @@ export function interceptPluginHook(
   name: string,
   hook: IHook,
 ) {
-  if (!hook.intercept) {
+  if (!hook?.intercept) {
     return;
   }