Address final feedback in RFC 190 for view=test #3907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the review of [RFC 190](web-platform-tests/rfcs#190), we agreed that we should: - Remove the button when in interop and allow this to be reachable by query parameter only. This change does that by removing the button added in #3753 The idea is to allow users to accomplish their workflows with view=test without confusing others. Another RFC would be needed to add a button. Additionally, since this RFC has been accepted, we can remove the feature flag gating it.
|
Reviewers can try it out by going to https://jcscottiii-enable-view-dot-wptdashboard-staging.uk.r.appspot.com/ and manually appending the |
KyleJu
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the review of RFC 190, we agreed that we should:
This change does that by removing the button added in #3753
The idea is to allow users to accomplish their
workflows with view=test without confusing others. Another RFC would be needed to add a button.
Additionally, since this RFC has been accepted, we can remove the feature flag gating it.