Use non-conflicting route for GitHub actions #4010
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 20, 2024
|
This makes this differ to the Azure Pipelines endpoint, which feels surprising. Maybe we should just reorder them in |
|
Oh, that would probably work, too. |
Turns out it doesn't and I don't know why. |
|
Closed in favor of #4017. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #4009. According to mux docs "Routes are tested in the order they were added to the router. If two routes match, the first one wins." The route
/api/checks/github-actionsis picked up by the handler for route/api/checks/{commit}. Presumably the route addition happens as packages are initialized in lexicographic order andcheckscomes beforeghactions.Tested locally with cURL, but #3981 would have helped here.