-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn on navigation to Interop 2025 #4229
Conversation
0278843
to
06b857c
Compare
0cb7891
to
1c1adb4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question about the mobile_csv_url in the two files.
webapp/components/interop-data.js
Outdated
@@ -1537,6 +1537,7 @@ export const interopData = { | |||
* https://github.com/web-platform-tests/results-analysis | |||
**/ | |||
'csv_url': 'https://raw.githubusercontent.com/web-platform-tests/results-analysis/gh-pages/data/interop-2025/interop-2025-{stable|experimental}-v2.csv', | |||
'mobile_csv_url': 'https://api.github.com/repos/jgraham/interop-results/contents/2025/latest/aligned/mobile-{stable|experimental}-current.csv?ref=main', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you want the raw.githubusercontent.com URL for the mobile url. Also, there are no stable results for now. I only see experimental results for mobile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the URL used for the mobile results for 2024 as well, but we handle the mobile url differently to obtain the raw results view:
wpt.fyi/webapp/components/interop-data-manager.js
Lines 389 to 396 in 1723707
if (isMobileScoresView) { | |
const respJson = await csvResp.json(); | |
const csvText = atob(respJson['content']); | |
csvLines = csvText.split('\r\n').filter(l => l); | |
} else { | |
const csvText = await csvResp.text(); | |
csvLines = csvText.split('\n').filter(l => l); | |
} |
There may be a better way of doing this, but this is what I found that worked 😅
Also, it is true that there are not stable results, but the link configuration is set up so that we can obtain stable results if they become available as scores.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually given the fact we will get stable results sometime this year, ignore my initial concern. My follow up question: If someone selects stable, what will happen given that no stable results exist yet?
Also, thanks for the code. That helped. I ran it through a REPL with the current JSON payload and it makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sets Interop 2025 as the default Interop year, and allows navigation to the 2025 dashboard.