Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on navigation to Interop 2025 #4229

Merged
merged 9 commits into from
Feb 12, 2025
Merged

Conversation

DanielRyanSmith
Copy link
Contributor

Sets Interop 2025 as the default Interop year, and allows navigation to the 2025 dashboard.

@DanielRyanSmith DanielRyanSmith changed the base branch from main to prep-interop-2025 February 6, 2025 23:06
Copy link
Collaborator

@jcscottiii jcscottiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about the mobile_csv_url in the two files.

@@ -1537,6 +1537,7 @@ export const interopData = {
* https://github.com/web-platform-tests/results-analysis
**/
'csv_url': 'https://raw.githubusercontent.com/web-platform-tests/results-analysis/gh-pages/data/interop-2025/interop-2025-{stable|experimental}-v2.csv',
'mobile_csv_url': 'https://api.github.com/repos/jgraham/interop-results/contents/2025/latest/aligned/mobile-{stable|experimental}-current.csv?ref=main',
Copy link
Collaborator

@jcscottiii jcscottiii Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want the raw.githubusercontent.com URL for the mobile url. Also, there are no stable results for now. I only see experimental results for mobile.

https://github.com/jgraham/interop-results/tree/4cb9d304ea32acd6c2d35a86ed486b8b0f0a02e7/2025/latest/aligned

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the URL used for the mobile results for 2024 as well, but we handle the mobile url differently to obtain the raw results view:

if (isMobileScoresView) {
const respJson = await csvResp.json();
const csvText = atob(respJson['content']);
csvLines = csvText.split('\r\n').filter(l => l);
} else {
const csvText = await csvResp.text();
csvLines = csvText.split('\n').filter(l => l);
}

There may be a better way of doing this, but this is what I found that worked 😅

Also, it is true that there are not stable results, but the link configuration is set up so that we can obtain stable results if they become available as scores.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually given the fact we will get stable results sometime this year, ignore my initial concern. My follow up question: If someone selects stable, what will happen given that no stable results exist yet?

Also, thanks for the code. That helped. I ran it through a REPL with the current JSON payload and it makes sense.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We currently have 3 categories that display on the dashboard when the flag is set for mobile results.

Screenshot 2025-02-12 11 01 44 AM

So if we obtain stable mobile results sometime, this design will have to change to be more explicit and allow for viewing both sets of data.

webapp/static/interop-data.json Outdated Show resolved Hide resolved
Base automatically changed from prep-interop-2025 to main February 11, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants