Add quiet flag to production deployment script #4263
Conversation
util/deploy-production.sh
Outdated
| if confirm "Delete $1 service version $OLDEST_REV?"; then | ||
| gcloud app versions delete --service=$SERVICE $OLDEST_REV | ||
| else | ||
| echo "Skipping $1 service version $OLDEST_REV" | ||
| fi | ||
| gcloud app versions delete --service=$SERVICE $OLDEST_REV ${QUIET:+--quiet} |
There was a problem hiding this comment.
A confirmation here is also removed because it is redundant with the confirmation that exists within the gcloud command, which made it required to confirm with 'y' twice
There was a problem hiding this comment.
Nit: put the flags together before the version parameter?
I agree that 2 confirmations were too many.
Makefile
Outdated
| @@ -300,7 +300,7 @@ cleanup_staging_versions: gcloud_login | |||
|
|
|||
| deploy_production: deployment_state | |||
| gcloud config set project wptdashboard | |||
| util/deploy.sh -r $(APP_PATH) | |||
| util/deploy.sh -r $(APP_PATH) ${QUIET:+-q} | |||
There was a problem hiding this comment.
Nit: I'd reorder and put the flags together, before the app parameter.
util/deploy-production.sh
Outdated
| -b : skip GitHub issue creation | ||
| -f : Always deploy (even if checks have failed)" | ||
| -f : Always deploy (even if checks have failed) | ||
| -q : Disable all interactive prompts when running gcloud deploy commands" |
There was a problem hiding this comment.
Nit: the quiet flag removes more things in deploy.sh, so I would rephrase it perhaps as "Disable all interactive prompts and debugging output".
While you are here, do you mind making capitalization more uniform by changing "skip" to "Skip" in the line above?
util/deploy-production.sh
Outdated
| if confirm "Delete $1 service version $OLDEST_REV?"; then | ||
| gcloud app versions delete --service=$SERVICE $OLDEST_REV | ||
| else | ||
| echo "Skipping $1 service version $OLDEST_REV" | ||
| fi | ||
| gcloud app versions delete --service=$SERVICE $OLDEST_REV ${QUIET:+--quiet} |
There was a problem hiding this comment.
Nit: put the flags together before the version parameter?
I agree that 2 confirmations were too many.
| wptd_exec_it make deploy_production PROJECT=wptdashboard APP_PATH=api/query/cache/service | ||
| wptd_exec_it make deploy_production PROJECT=wptdashboard APP_PATH=webapp/web ${QUIET:+QUIET=true} | ||
| wptd_exec_it make deploy_production PROJECT=wptdashboard APP_PATH=results-processor ${QUIET:+QUIET=true} | ||
| wptd_exec_it make deploy_production PROJECT=wptdashboard APP_PATH=api/query/cache/service ${QUIET:+QUIET=true} |
There was a problem hiding this comment.
Don't you need to similarly update the Makefile for this as well?
There was a problem hiding this comment.
deploy.sh actually already has a quiet flag implemented as well 🙂
This change adds a
-qflag to the production deployment script, which adds the--quietflag to certain gcloud commands.The deployment script takes a long time to deploy (20+ minutes) and includes a number of confirmation prompts throughout the process. This change should make it easier to handle the deployment process with minimal supervision.
The new flag removes the confirmation steps for:
The new flag does NOT remove the confirmation steps for: