Skip to content

Commit

Permalink
Revert "Store bit for paint offset translation was present before rea…
Browse files Browse the repository at this point in the history
…ttach"

This reverts commit 756c3e7736d91560f2ff85914be31c30316c13fa.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 849919 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzc1NmMzZTc3MzZkOTE1NjBmMmZmODU5MTRiZTMxYzMwMzE2YzEzZmEM

Sample Failed Build: https://ci.chromium.org/b/8856342357767509280

Sample Failed Step: xr_browser_tests

Original change's description:
> Store bit for paint offset translation was present before reattach
>
> This allows PaintPropertyTreeBuilder to skip any paint offset
> translation for a reattached node in the subsequent pre-paint, because
> if the previous frame encountered a paint offset translation, the
> paint offset of the object does not aggregate across it. Therefore
> the old and new paint offsets both skip it and the new one should
> also be skipped.
>
> The bit helps to distinguish between the case of a paint offset
> translation re-allocated due to reattach and deletion of a LayoutObject,
> vs a style change that caused a new paint offset translation to be
> allocated.
>
> Fixed: 1170400
>
> Change-Id: I4b057cbcec3a8d72b0beeda7a0f3e34f99a605ef
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2666949
> Commit-Queue: Chris Harrelson <[email protected]>
> Reviewed-by: Xianzhu Wang <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#849919}

Change-Id: I9f5e6d769e6b77937541b0aa70e9a164432b4252
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2671539
Cr-Commit-Position: refs/heads/master@{#850008}
  • Loading branch information
Findit authored and chromium-wpt-export-bot committed Feb 3, 2021
1 parent 289272c commit 5cbf4a1
Showing 1 changed file with 0 additions and 32 deletions.
32 changes: 0 additions & 32 deletions layout-instability/display-change-with-transform.html

This file was deleted.

0 comments on commit 5cbf4a1

Please sign in to comment.