Skip to content

Commit

Permalink
Fix dir=auto traversal to not apply element-only rules to ancestors
Browse files Browse the repository at this point in the history
This fixes Chromium code to match half of the spec update in
whatwg/html#10488 and
whatwg/html#10561 .  I previously thought the
code was fine, but I realize a small update is needed.  In particular,
the code could apply element-only rules for dir=auto to elements (in
particular, button-type inputs) that are auto-directionality
form-associated elements but were not in the list of exclusions.  This
also fixes the list of exclusions to exclude specifically textarea, so
that any actual text content of input elements (but not the value) is
traversed as required by the spec.

This also removes the no-longer needed is_deferred argument to
ResolveAutoDirectionality.

Bug: 576815, 352191350
Change-Id: I7c13b9661d23f8904727c8298a8dca6360d6d732
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5798880
Commit-Queue: David Baron <[email protected]>
Reviewed-by: Di Zhang <[email protected]>
Commit-Queue: Di Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1344402}
  • Loading branch information
dbaron authored and chromium-wpt-export-bot committed Aug 20, 2024
1 parent 07a9d09 commit 7d90ab7
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,7 @@
<div id=root>
<input value="اختبر">
<input type=text value="اختبر">
<input type=submit value="اختبر">
abc
</div>
</div>
Expand Down

0 comments on commit 7d90ab7

Please sign in to comment.