Skip to content

Commit

Permalink
Remove DCHECK for invariant fragment inline-size.
Browse files Browse the repository at this point in the history
Even if variable fragmentainer inline-size isn't yet possible (it will,
though, once we add support for named pages for printing), a node may
still generate fragments with variable inline-size, thanks to floats.

Remove the DCHECK. We already handle this correctly on the NG side. For
the legacy side, there isn't much we can do.

Bug: 1295667
Change-Id: I70428db1cae1368b34055c4c3b7f62ce3d23a2c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3468474
Reviewed-by: Ian Kilpatrick <[email protected]>
Commit-Queue: Morten Stenshorne <[email protected]>
Cr-Commit-Position: refs/heads/main@{#972340}
  • Loading branch information
mstensho authored and chromium-wpt-export-bot committed Feb 17, 2022
1 parent a8bd81b commit a286838
Show file tree
Hide file tree
Showing 2 changed files with 41 additions and 0 deletions.
30 changes: 30 additions & 0 deletions css/css-break/fragmented-autowidth-fc-root-beside-floats-ref.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
<!DOCTYPE html>
<link rel="author" title="Morten Stenshorne" href="mailto:[email protected]">
<style>
.fakecolumn {
float: left;
width: 200px;
height: 100px;
margin-left: 10px;
}
.fakecolumn:first-child {
margin-left: 0;
}
.part {
height: 100px;
background: hotpink;
}
</style>
<p>There should be (from left to right) a hotpink square, a thin hotpink
rectangle, then a wider hotpink rectangle.</p>
<div style="width:620px; height:100px;">
<div class="fakecolumn">
<div class="part" style="width:100px;"></div>
</div>
<div class="fakecolumn">
<div class="part" style="width:10px;"></div>
</div>
<div class="fakecolumn">
<div class="part" style="width:200px;"></div>
</div>
</div>
11 changes: 11 additions & 0 deletions css/css-break/fragmented-autowidth-fc-root-beside-floats.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!DOCTYPE html>
<link rel="author" title="Morten Stenshorne" href="mailto:[email protected]">
<link rel="help" href="https://www.w3.org/TR/css-break-3/#varying-size-boxes">
<link rel="match" href="fragmented-autowidth-fc-root-beside-floats-ref.html">
<p>There should be (from left to right) a hotpink square, a thin hotpink
rectangle, then a wider hotpink rectangle.</p>
<div style="columns:3; column-gap:10px; column-fill:auto; width:620px; height:100px;">
<div style="float:right; width:100px; height:60px;"></div>
<div style="clear:both; float:right; break-inside:avoid; width:190px; height:60px;"></div>
<div style="display:flow-root; height:300px; background:hotpink;"></div>
</div>

0 comments on commit a286838

Please sign in to comment.