Set Sec-Fetch-Mode from the network service.
#18838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 4, 2019
chromium-wpt-export-bot
changed the title
Sec-Fetch-Mode from the network service.Sec-Fetch-Mode from the network service.
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1780725
branch
from
74eea41
to
8d91eee
Compare
In order to move `Sec-Fetch-Mode` into the network service to ensure
that it's consistently set every time `Sec-Fetch-Site` is set, this
patch does a few things:
1. Based on the conversation in [1] and [2], this patch extends
`network::mojom::RequestMode` to include two new values to
represent nested navigations and object/embed navigations as
distinct from main-frame navigations.
2. It introduces a new `network::IsNavigationRequestMode()` function
to replace direct comparisons to `kNavigate` in various parts of
the codebase.
3. It refactors `network::SetSecFetchSiteHeader()` into
`network::SetFetchMetadataHeaders()`. This creates a single entry
point from `URLLoader` to set all Fetch Metadata headers, and
fleshes out the `Sec-Fetch-Mode` header.
[1]: w3c/webappsec-fetch-metadata#37
[2]: whatwg/fetch#755
Bug: 972263, 990864
Change-Id: Icd20c7640d3d08ecb34a739f0203140fdcc195d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780725
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Łukasz Anforowicz <[email protected]>
Commit-Queue: Mike West <[email protected]>
Cr-Commit-Position: refs/heads/master@{#693517}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1780725
branch
from
8d91eee
to
57d22ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to move
Sec-Fetch-Modeinto the network service to ensurethat it's consistently set every time
Sec-Fetch-Siteis set, thispatch does a few things:
Based on the conversation in 1 and 2, this patch extends
network::mojom::RequestModeto include two new values torepresent nested navigations and object/embed navigations as
distinct from main-frame navigations.
It introduces a new
network::IsNavigationRequestMode()functionto replace direct comparisons to
kNavigatein various parts ofthe codebase.
It refactors
network::SetSecFetchSiteHeader()intonetwork::SetFetchMetadataHeaders(). This creates a single entrypoint from
URLLoaderto set all Fetch Metadata headers, andfleshes out the
Sec-Fetch-Modeheader.Bug: 972263, 990864
Change-Id: Icd20c7640d3d08ecb34a739f0203140fdcc195d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780725
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Łukasz Anforowicz <[email protected]>
Commit-Queue: Mike West <[email protected]>
Cr-Commit-Position: refs/heads/master@{#693517}