Deduplicate some WPT. #42700
Merged
Deduplicate some WPT. #42700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 23, 2023
storagemanager-estimate and estimate-indexeddb are more or less the same tests, the latter having been ported from the former to use `async`/`await`. The former probably should have been deleted when the latter was introduced. Since some of the tests are related to IndexedDB and some are not, this change keeps the IndexedDB tests in the file called `estimate-indexeddb` and keeps the basic tests in `storagemanager-estimate` (with minor updates). One wrinkle from the Chromium side is that the behavior of `storageManager.estimate()` is not actually specced, and as the Chromium implementation uses LevelDB, which behaves in mysterious ways, adding things to the database does NOT always increase the reported usage size. Both of these tests operate on large things, which typically do increase usage, however we noticed that for one reason or another, the test that adds an *uninitialized* ArrayBuffer starts failing on Windows if durability is set to relaxed. There are other ways to make the test fail as well: using a shorter name for the database, or putting small values, does not reliably increase the reported usage. This is all fine in the sense that it isn't defined behavior, but it does suggest that working in this area or on tests of this ilk is a bit of a minefield. These tests probably should not exist as WPT, at least not until quota behavior is specced (see whatwg/storage#110). But it would also be sort of a shame to delete WPT that are passing, so I've left them in place for now. Bug: 1489517 Change-Id: I6619f504ce92e428054691ac6bf54a0e14e3ce5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4968659 Commit-Queue: Evan Stade <[email protected]> Reviewed-by: Ayu Ishii <[email protected]> Cr-Commit-Position: refs/heads/main@{#1214324}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4968659
branch
from
bccaa73 to
7004a8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
storagemanager-estimate and estimate-indexeddb are more or less the
same tests, the latter having been ported from the former to use
async/await. The former probably should have been deleted when thelatter was introduced.
Since some of the tests are related to IndexedDB and some are not, this
change keeps the IndexedDB tests in the file called
estimate-indexeddband keeps the basic tests in
storagemanager-estimate(with minorupdates).
One wrinkle from the Chromium side is that the behavior of
storageManager.estimate()is not actually specced, and as the Chromiumimplementation uses LevelDB, which behaves in mysterious ways, adding
things to the database does NOT always increase the reported usage size.
Both of these tests operate on large things, which typically do increase
usage, however we noticed that for one reason or another, the test that
adds an uninitialized ArrayBuffer starts failing on Windows if
durability is set to relaxed. There are other ways to make the test fail
as well: using a shorter name for the database, or putting small
values, does not reliably increase the reported usage. This is all fine
in the sense that it isn't defined behavior, but it does suggest that
working in this area or on tests of this ilk is a bit of a minefield.
These tests probably should not exist as WPT, at least not until quota
behavior is specced (see whatwg/storage#110).
But it would also be sort of a shame to delete WPT that are passing, so
I've left them in place for now.
Bug: 1489517
Change-Id: I6619f504ce92e428054691ac6bf54a0e14e3ce5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4968659
Commit-Queue: Evan Stade <[email protected]>
Reviewed-by: Ayu Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1214324}