Add getHTML() and modify getInnerHTML() accordingly [2/2] #44107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 20, 2024
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5219591
branch
from
1603ab6 to
00eda56
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5219591
branch
7 times, most recently
from
455c50b to
22ca36b
Compare
This CL adds a new getHTML() method, and modifies the existing getInnerHTML() method accordingly. The behavior of getInnerHTML() is not changed by this CL, but the implementation is modified to allow the code to be shared. The new method follows the discussion and conclusions here: whatwg/html#8867 (comment) Essentially, that is: 1. Provide a boolean option to getHTML() that says "please serialize opted-in shadow roots". The default for this option is false. 2. Provide an option to getHTML() containing a sequence of shadowRoots that should be serialized, independent of whether they opted in via the flag above. This work falls under these two chromestatus entries: https://chromestatus.com/feature/5081733588582400 https://chromestatus.com/feature/5102952270528512 and these two blink-dev threads: https://groups.google.com/a/chromium.org/g/blink-dev/c/PE4VwMjLVTo https://groups.google.com/a/chromium.org/g/blink-dev/c/it0X7BOimKw Bug: 1519972, 1517959 Change-Id: I5181a0702a12d550b4dab64c0c306ea2ccb25fa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5219591 Commit-Queue: Mason Freed <[email protected]> Reviewed-by: David Baron <[email protected]> Cr-Commit-Position: refs/heads/main@{#1251541}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5219591
branch
from
22ca36b to
16c92ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds a new getHTML() method, and modifies the existing
getInnerHTML() method accordingly. The behavior of getInnerHTML()
is not changed by this CL, but the implementation is modified to allow
the code to be shared. The new method follows the discussion and
conclusions here:
whatwg/html#8867 (comment)
Essentially, that is:
opted-in shadow roots". The default for this option is false.
that should be serialized, independent of whether they opted in via
the flag above.
This work falls under these two chromestatus entries:
https://chromestatus.com/feature/5081733588582400
https://chromestatus.com/feature/5102952270528512
and these two blink-dev threads:
https://groups.google.com/a/chromium.org/g/blink-dev/c/PE4VwMjLVTo
https://groups.google.com/a/chromium.org/g/blink-dev/c/it0X7BOimKw
Bug: 1519972, 1517959
Change-Id: I5181a0702a12d550b4dab64c0c306ea2ccb25fa3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5219591
Commit-Queue: Mason Freed <[email protected]>
Reviewed-by: David Baron <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1251541}