Update dir=auto traversal tests to not apply element-only rules to ancestors #47678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cestors This fixes web platform tests to match half of the spec update in whatwg/html#10488 and whatwg/html#10561 . Prior to this change (in spec and Gecko, although not in the Chromium code) the special rules for dir=auto traversals that were intended to apply only to dir=auto on an element and not to dir=auto on its ancestors (relating to auto-directionality form-associated elements and to slots) were being applied in one ancestor case, where the special element was an assigned node of a slot. This makes the test changes corresponding to the fix to the HTML spec. Bug: 576815, 352191350 Change-Id: I6ffa8e22acc6f71777df1165655eaa1c8891867e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5798082 Commit-Queue: David Baron <[email protected]> Reviewed-by: Di Zhang <[email protected]> Cr-Commit-Position: refs/heads/main@{#1343842}
wpt-pr-bot
approved these changes
Aug 20, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes web platform tests to match half of the spec update in
whatwg/html#10488 and
whatwg/html#10561 . Prior to this change (in
spec and Gecko, although not in the Chromium code) the special rules for
dir=auto traversals that were intended to apply only to dir=auto on an
element and not to dir=auto on its ancestors (relating to
auto-directionality form-associated elements and to slots) were being
applied in one ancestor case, where the special element was an assigned
node of a slot. This makes the test changes corresponding to the fix to
the HTML spec.
Bug: 576815, 352191350
Change-Id: I6ffa8e22acc6f71777df1165655eaa1c8891867e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5798082
Commit-Queue: David Baron <[email protected]>
Reviewed-by: Di Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1343842}