Require ::picker(select) appearance:base-select opt-in #47965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch requires that not only appearance:base-select be applied to <select> to make the popup be a popover, but also for appearance:base-select to be applied to select::picker(select). This is being discussed here: w3c/csswg-drafts#10440 Change-Id: Ib089a9f8a4c0bea30d2f4fb9da1df185f4272db0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5819694 Commit-Queue: Joey Arhar <[email protected]> Reviewed-by: David Baron <[email protected]> Cr-Commit-Position: refs/heads/main@{#1350885}
wpt-pr-bot
approved these changes
Sep 4, 2024
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5819694
branch
from
bfa8deb
to
18213ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch requires that not only appearance:base-select be applied to
<select> to make the popup be a popover, but also for
appearance:base-select to be applied to select::picker(select). This is
being discussed here: w3c/csswg-drafts#10440
Change-Id: Ib089a9f8a4c0bea30d2f4fb9da1df185f4272db0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5819694
Commit-Queue: Joey Arhar <[email protected]>
Reviewed-by: David Baron <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1350885}