Rename Animation.progress to Animation.overallProgress #49385
Conversation
|
This export is manually created to resolve conflict with 24c2e5fb6cb |
web-animations/interfaces/Animation/scroll-timeline-overallProgress.tentative.html
Outdated
Show resolved
Hide resolved
In line with the CSS working group resolution in web-platform-tests#8799[1], this patch renames Animation.progress in to Animation.overallProgress in Blink. [1] w3c/csswg-drafts#8799 (comment) Bug: 40914396 Change-Id: Ie7605f59d99314158b77e9672dbe98a564d2d1e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6049834 Commit-Queue: David Awogbemila <[email protected]> Reviewed-by: Robert Flack <[email protected]> Cr-Commit-Position: refs/heads/main@{#1387916}
dev-ansung
force-pushed
the
1126-importer
branch
from
a541aa4 to
0d56ec5
Compare
|
For my own education: what is the purpose of this patch? It appears to be just a formatting change. If so, is there a guideline for this formatting? This is so I respect it going forward since 24c2e5fb6cb should have followed it. |
Chromium follows pep8 which has a line length limit of 79 characters, but that is not the reason why this patch is needed. It is needed because the same file renaming also happened in chromium source code and the two-way-sync cannot handle the conflict. |
In line with the CSS working group resolution in #8799[1], this patch renames Animation.progress in to Animation.overallProgress in Blink.
[1] w3c/csswg-drafts#8799 (comment)
Bug: 40914396
Change-Id: Ie7605f59d99314158b77e9672dbe98a564d2d1e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6049834
Commit-Queue: David Awogbemila [email protected]
Reviewed-by: Robert Flack [email protected]
Cr-Commit-Position: refs/heads/main@{#1387916}