[wptrunner] Add a new argument for the wpt cli to pass custom Android activity names #50818
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are these changes
This supports plumbing custom activity names for running WPT on Android applications.
Why make these changes
Currently, it is only possible to run WPT for Android webviews when the activity name is exactly
org.chromium.webview_shell.WebPlatformTestsActivity
. This makes it complicated to run WPT on webviews in applications other than the reference activity provided by Chromium.How to use this functionality
./wpt run --package-name com.my.application --activity-name com.my.application.MyActivity android_webview
Potential modifications
As you can see in the above example, the package name is repeated (
com.my.application
). It might be simpler to compose theactivity_name
by concatenating thepackage_name
and just the final activity name (MyActivity
). I avoided this design because it would change the existing behaviour for users who already override the package name.