Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wptrunner] Add a new argument for the wpt cli to pass custom Android activity names #50818

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SamuelWeiss
Copy link

What are these changes
This supports plumbing custom activity names for running WPT on Android applications.

Why make these changes
Currently, it is only possible to run WPT for Android webviews when the activity name is exactly org.chromium.webview_shell.WebPlatformTestsActivity. This makes it complicated to run WPT on webviews in applications other than the reference activity provided by Chromium.

How to use this functionality
./wpt run --package-name com.my.application --activity-name com.my.application.MyActivity android_webview

Potential modifications
As you can see in the above example, the package name is repeated (com.my.application). It might be simpler to compose the activity_name by concatenating the package_name and just the final activity name (MyActivity). I avoided this design because it would change the existing behaviour for users who already override the package name.

@wpt-pr-bot wpt-pr-bot added infra wptrunner The automated test runner, commonly called through ./wpt run labels Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants