[Gecko Bug 1944054] Handle 'transparent' when interpolating midpoint hints in the gradient color line. #50936
+73
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t color line. Includes test that fails without the patch, and passes with it. (I'm a bit unclear whether the spec explicitly requires this behavior, but it appears to match what both Blink and WebKit are doing, so for the sake of interoperability and predictable behavior, I think it makes sense to do the same.) Differential Revision: https://phabricator.services.mozilla.com/D239387 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1944054 gecko-commit: 8d57637699f643cd81412ce22009c870c7df1040 gecko-reviewers: layout-reviewers, emilio
wpt-pr-bot
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes test that fails without the patch, and passes with it.
(I'm a bit unclear whether the spec explicitly requires this behavior,
but it appears to match what both Blink and WebKit are doing, so for
the sake of interoperability and predictable behavior, I think it
makes sense to do the same.)
Differential Revision: https://phabricator.services.mozilla.com/D239387
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1944054
gecko-commit: 8d57637699f643cd81412ce22009c870c7df1040
gecko-reviewers: layout-reviewers, emilio