Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update peer dependeny web3.js #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update peer dependeny web3.js #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c81b68a
update peer dependency web3
luu-alex Dec 9, 2024
56cd0db
major bump version
luu-alex Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "web3-plugin-template",
"version": "1.0.0",
"version": "2.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think. We do not need to change the version so much with these changes. It would be better to set 1.0.1 for ex.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also gree.
I am not sure. But maybe something like:

Suggested change
"version": "2.0.0",
"version": "1.1.0",

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, I'll check to make sure that the peer dependency update breaks anything before we can commit to a version update

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I think 1.0.1 is a better choice for the version, per semantic versioning. Bumping the minor version (i.e. 1.1.0) would indicate that new non-breaking features were added. The third version number (patch) is the "fix" version and indicates that some existing feature was fixed. Ref: https://semver.org/

"description": "Template plugin to extend web3.js with additional methods",
"main": "lib/index.js",
"types": "lib/index.d.ts",
Expand All @@ -21,8 +21,7 @@
"type": "git",
"url": "[email protected]:web3/web3.js-plugin-template.git"
},
"dependencies": {
},
"dependencies": {},
"devDependencies": {
"@chainsafe/eslint-config": "^2.0.0",
"@types/jest": "^29.5.2",
Expand All @@ -36,6 +35,6 @@
"web3": "^4.2.2"
},
"peerDependencies": {
"web3": ">= 4.0.3"
"web3": ">= 4.12.0"
}
}
Loading
Loading