Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation about create2 method #7418

Closed

Conversation

pamellix
Copy link

@pamellix pamellix commented Dec 7, 2024

Description

#7369
Added the documentation for create2ContractAddress:

  • Included JSDoc comments directly in the function definition.

Type of change

  • Documentation (changes that only address relatively minor typographical errors are not accepted)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@pamellix
Copy link
Author

@avkos my PR is ready to merge? May you do make merge?

@jdevcs
Copy link
Contributor

jdevcs commented Jan 21, 2025

Thank you for your pull request. We appreciate your contributions to the Web3.js library.
As you may be aware, we are in the process of sunsetting Web3.js, and as such, we will not be merging any non-critical pull requests.
Our focus during this transition will be on addressing critical issues to ensure a smooth migration for our users.
For further details regarding the sunsetting of Web3.js, please refer to the official announcement here: Web3.js Sunset Announcement

@jdevcs jdevcs closed this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants